-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This pull request relates to two issues, #41427 and #41213 #26233
Open
Terrencezzz
wants to merge
17
commits into
brave:master
Choose a base branch
from
Terrencezzz:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d the pref_names.h for webtorrent policy.
…ents/prefs/pref_service.h" in webtorrent_util.cc
Change padding to em units instead of px so it scales with size instead of constant units
…n-with-search-button
…n-with-search-button
…n-with-search-button
…-button-with-search-button Deal with overlapping of delete button with search button #41213
…btorrent Add group policy to disable webtorrent
Terrencezzz
changed the title
This branch has two related issues, disable webtorrent and fix icon overlap
This branch has two related issues, #41427 and #41213
Oct 25, 2024
Terrencezzz
changed the title
This branch has two related issues, #41427 and #41213
This pull request relates issues, #41427 and #41213
Oct 25, 2024
Terrencezzz
changed the title
This pull request relates issues, #41427 and #41213
This pull request relates to two issues, #41427 and #41213
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: