Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS] Fix crash when dismissing news opt-in on NTP (uplift to 1.70.x) #26234

Merged
merged 1 commit into from
Oct 25, 2024
Merged

iOS] Fix crash when dismissing news opt-in on NTP (uplift to 1.70.x) #26234

merged 1 commit into from
Oct 25, 2024

Conversation

StephenHeaps
Copy link
Collaborator

@StephenHeaps StephenHeaps commented Oct 25, 2024 •
edited by kjozwiak
Loading

Uplift of #26228
Resolves brave/brave-browser#41858

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@StephenHeaps StephenHeaps added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Oct 25, 2024
@StephenHeaps StephenHeaps self-assigned this Oct 25, 2024
@StephenHeaps StephenHeaps requested a review from a team as a code owner October 25, 2024 16:20
@kjozwiak kjozwiak added this to the 1.70.x - Release #6 milestone Oct 25, 2024
kjozwiak
kjozwiak approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.70.x approved 👍

@kjozwiak kjozwiak merged commit 082ea7f into 1.70.x Oct 25, 2024
16 checks passed
@kjozwiak kjozwiak deleted the uplift/1.70.x-bugfix-dismiss-news-opt-in branch October 25, 2024 19:09
@brave-builds
Copy link
Collaborator

Released in v1.70.133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@StephenHeaps StephenHeaps

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Milestone
1.70.x - Release #6
Development

Successfully merging this pull request may close these issues.
3 participants
@StephenHeaps @brave-builds @kjozwiak