Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve an issue with automatic flag for timezone (uplift to 1.71.x) #26243

Conversation

brave-builds
Copy link
Collaborator

Uplift of #26210
Resolves brave/brave-browser#41869

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner October 25, 2024 17:52
@brave-builds brave-builds added this to the 1.71.x - Release #3 milestone Oct 25, 2024
@brave-builds brave-builds self-assigned this Oct 25, 2024
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per discussion with @deeppandya., we'll get the above fixed via 1.72.x. I'm running into issues where I can't get Denver to be selected. @Uni-verse is also running into an issue where Denver isn't being selected once you've re-enabled Automatic. We'll investigate/get the above fixed for 1.72.x.

@kjozwiak kjozwiak closed this Oct 29, 2024
@kjozwiak kjozwiak deleted the pr26210_update_automatic_flag_behaviour_vpn_1.71.x branch October 29, 2024 18:48
@kjozwiak kjozwiak removed this from the 1.71.x - Release #3 milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants