Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(privacy): Shred intermittently not clearing all data #26246

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix(privacy): Shred intermittently not clearing all data #26246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ios/brave-ios/Sources/Brave/Frontend/Browser/TabManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,6 +851,10 @@ class TabManager: NSObject {
// Remove all unwanted tabs
for tab in allTabs {
guard tab.url?.baseDomain == etldP1 else { continue }
// The Tab's WebView is not deinitialized immediately, so it's possible the
// WebView still stores data after we shred but before the WebView is deinitialized.
// Delete the web view to prevent data being stored after data is Shred.
tab.deleteWebView()
removeTab(tab)
}

Expand Down
Loading