Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate extensions sidebar override to use Lit #26256

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Migrate extensions sidebar override to use Lit #26256

merged 1 commit into from
Oct 28, 2024
+24 −29

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Oct 28, 2024

Resolves brave/brave-browser#41917

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@emerick emerick self-assigned this Oct 28, 2024
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Oct 28, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

fallaciousreasoning
fallaciousreasoning approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % nit

browser/resources/extensions/brave_overrides/side_bar.ts Outdated Show resolved Hide resolved
@emerick
Migrate extensions sidebar override to use Lit
21ba5d9 
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/b926b290454f361d1ca67ee185a41a32aed62f0d

commit b926b290454f361d1ca67ee185a41a32aed62f0d
Author: rbpotter <rbpotter@chromium.org>
Date:   Wed Oct 2 20:53:24 2024 +0000

    Extensions: Migrate sidebar and toolbar to Lit

    Bug: 40943652
@emerick emerick force-pushed the cr131-followup-fix-extensions-sidebar-styles branch from e229d29 to 21ba5d9 Compare October 28, 2024 21:15
fallaciousreasoning
fallaciousreasoning approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still lgtm

@emerick emerick merged commit 38774a3 into master Oct 28, 2024
17 checks passed
@emerick emerick deleted the cr131-followup-fix-extensions-sidebar-styles branch October 28, 2024 22:55
@github-actions github-actions bot added this to the 1.73.x - Nightly milestone Oct 28, 2024
@emerick emerick mentioned this pull request Oct 28, 2024
Merged
24 tasks
emerick added a commit that referenced this pull request Oct 28, 2024
@emerick
Merge pull request #26256 from brave/cr131-followup-fix-extensions-si…
503d59c 
…debar-styles

Migrate extensions sidebar override to use Lit
@brave-builds
Copy link
Collaborator

Released in v1.73.54

emerick added a commit that referenced this pull request Oct 30, 2024
@emerick
Merge pull request #26256 from brave/cr131-followup-fix-extensions-si…
6da8b82 
…debar-styles

Migrate extensions sidebar override to use Lit
emerick added a commit that referenced this pull request Oct 30, 2024
@emerick
Merge pull request #26256 from brave/cr131-followup-fix-extensions-si…
89b228a 
…debar-styles

Migrate extensions sidebar override to use Lit
emerick added a commit that referenced this pull request Oct 30, 2024
@emerick
Merge pull request #26256 from brave/cr131-followup-fix-extensions-si…
4a07f3b 
…debar-styles

Migrate extensions sidebar override to use Lit
kjozwiak pushed a commit that referenced this pull request Oct 31, 2024
@emerick @brave-builds
@bsclifton @simonhong @samartnik
Upgrade from Chromium 130 to Chromium 131 1.72.x (#26222)
2af1342 
* Upgrade from Chromium 130.0.6723.70 to Chromium 130.0.6723.91 (1.72.x) (#26296)

* Upgrade from Chromium 130.0.6723.70 to Chromium 130.0.6723.91

* Update pins list timestamp

---------

Co-authored-by: brave-builds <brave-builds+devops@brave.com>

* Merge pull request #25662 from brave/cr131

Upgrade from Chromium 130 to Chromium 131.

* Merge pull request #26256 from brave/cr131-followup-fix-extensions-sidebar-styles

Migrate extensions sidebar override to use Lit

* Merge pull request #26277 from brave/cr131-followup-disable-https-first-balanced-mode

Disable HTTPS first balanced mode

* Fixed SearchEngineProviderServiceTest.PRE_InvalidPrivateSearchProviderRestoreTest

fix brave/brave-browser#41470

TemplateURLService should be loaded before setting
prefs::kSyncedDefaultPrivateSearchProviderGUID prefs.

* [Android] Fix for crash in Password settings

Chromium change:
https://source.chromium.org/chromium/chromium/src/+/df77cbacb9476b0b6d3e75cc34b5d127985e79c3

[Settings] Enable the single-activity mode by default

Bug: b/356743945

* [Android] Explicitly remove `New tab page cards` from menu

This item used in the upstream NTP, that we don't use.

---------

Co-authored-by: brave-builds <brave-builds+devops@brave.com>
Co-authored-by: Brian Clifton <brian@clifton.me>
Co-authored-by: Simon Hong <shong@brave.com>
Co-authored-by: Artem Samoilenko <artem@brave.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fallaciousreasoning fallaciousreasoning fallaciousreasoning approved these changes

Assignees

@emerick emerick

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.73.x - Nightly
Development

Successfully merging this pull request may close these issues.

CR131 - My extension and Keyboard shortcuts button color and mouse hover effect is inherited from chrome
3 participants
@emerick @brave-builds @fallaciousreasoning