Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeHealth] Disallow new NOTREACHED_IN_MIGRATION uses #26297

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

cdesouza-chromium
Copy link
Collaborator

This PR adds a new presubmit check to prevent the introduction of new occurrences for NOTREACHED_IN_MIGRATION. This macro is supposed to be on its way out, however there are still new occurrances being introduced in recent times.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

This PR adds a new presubmit check to prevent the introduction of new
occurrences for `NOTREACHED_IN_MIGRATION`. This macro is supposed to be
on its way out, however there are still new occurrances being introduced
in recent times.
@cdesouza-chromium cdesouza-chromium self-assigned this Oct 30, 2024
@cdesouza-chromium cdesouza-chromium changed the title [CodeHealth] Disallow new NOTREACHED_IN_MIGRATION instances [CodeHealth] Disallow new NOTREACHED_IN_MIGRATION uses Oct 30, 2024
@cdesouza-chromium cdesouza-chromium merged commit 3b462c7 into master Oct 30, 2024
18 checks passed
@cdesouza-chromium cdesouza-chromium deleted the disallow-not-reached-in-migration branch October 30, 2024 04:07
@github-actions github-actions bot added this to the 1.73.x - Nightly milestone Oct 30, 2024
@brave-builds
Copy link
Collaborator

Released in v1.73.60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants