Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BraveVPNController to BrowserWindowFeatures #26299

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Oct 30, 2024

fix brave/brave-browser#41973

BraveVPNController will control vpn behavior related with browser window.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Launch browser with clean profile on Windows/macOS
  2. Click Brave VPN entry from app menu
  3. Check vpn bubble is shown

@simonhong simonhong self-assigned this Oct 30, 2024
@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Oct 30, 2024
@simonhong simonhong force-pushed the introduce_brave_vpn_controller branch 2 times, most recently from 483f3f1 to 98ae5f6 Compare October 30, 2024 12:05
@simonhong simonhong marked this pull request as ready for review October 30, 2024 14:14
@simonhong simonhong requested a review from a team as a code owner October 30, 2024 14:14
private:
BraveBrowserView* GetBraveBrowserView();

raw_ptr<BrowserView, DanglingUntriaged> browser_view_ = nullptr;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdesouza-chromium should new raw_ptr entries include DanglingUntriaged for now?

Copy link
Collaborator

@cdesouza-chromium cdesouza-chromium Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we don't want to introduce new cases of DanglingUntriaged in new code. brave/security-action#697

Unfortunately I've not been able to switch on the detector on linux yet, but I hope to get it done by tomorrow.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted annotation. I think BraveVPNController could not ref the dangled one.

fix brave/brave-browser#41973

BraveVPNController will control vpn behavior related with browser window.
@simonhong simonhong force-pushed the introduce_brave_vpn_controller branch from 98ae5f6 to 75e2ab4 Compare October 31, 2024 01:52
@simonhong simonhong requested a review from goodov October 31, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add BraveVPNController to BrowserWindowFeatures
3 participants