[ads] General code health

[tmancey]

Resolves brave/brave-browser#41985

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• x ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

[github-actions]

[puLL-Merge] - brave/brave-core@26303

Here's my review of the pull request:

Description

This PR makes several changes to the Brave Ads codebase, primarily focusing on refactoring and improving the challenge bypass ristretto implementation. It introduces new type aliases for token-related data structures, updates function signatures, and modifies the handling of tokens throughout the codebase. Additionally, it includes some changes to the tab management system and updates to the condition matcher documentation.

Changes

Changes

1. challenge_bypass_ristretto:

   • Introduced new type aliases: TokenList, BlindedTokenList, SignedTokenList, and UnblindedTokenList.
   • Updated function signatures and variable types to use these new aliases.
   • Removed unnecessary #include statements and updated others.

2. token_generator:

   • Updated the Generate function to return cbr::TokenList instead of std::vector<cbr::Token>.
   • Modified related test files and mock objects accordingly.

3. tab_manager:

   • Reordered notification methods in TabManager and TabManagerObserver.

4. user_activity_manager:

   • Updated the order of overridden methods to match the new TabManagerObserver order.

5. purchase_intent_processor:

   • Swapped the implementation of OnTabDidChange and OnDidOpenNewTab.

6. condition_matcher_util:

   • Significantly updated the documentation for condition matchers, including more detailed explanations and examples.
   • Added information about virtual pref paths and their uses.

7. view_counter_service:

   • Added a comment about where condition matchers should be included for non-Rewards users.

Possible Issues

None identified. The changes appear to be mostly refactoring and improvements to existing code.

Security Hotspots

None identified. The changes do not introduce any apparent security vulnerabilities.

Overall, this PR appears to be a well-structured refactoring effort that improves code organization and documentation. The introduction of type aliases for token-related data structures should improve code readability and maintainability.

[brave-builds]

Released in v1.73.62