Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI run for contributor PR #24543 #26313

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

CI run for contributor PR #24543 #26313

wants to merge 7 commits into from
+99 −9

Commits on Oct 31, 2024

  1. When opening the browser in incognito mode from command line, we shou… 

    …ld prevent deleting the origins marked with "Forget me when I close this site".

The reason for this is that the incognito window does not re-create the lifetime of TLD from the main profile and as a result, they get scheduled for deletion.
    @Ilie-Lesan @brave-browser-releases
    Ilie-Lesan authored and brave-browser-releases committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    99818e6 View commit details
    Browse the repository at this point in the history

  2. Address review remarks

    @Ilie-Lesan @brave-browser-releases
    Ilie-Lesan authored and brave-browser-releases committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    7643037 View commit details
    Browse the repository at this point in the history

  3. Add browser tests

    @Ilie-Lesan @brave-browser-releases
    Ilie-Lesan authored and brave-browser-releases committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    dce32b1 View commit details
    Browse the repository at this point in the history

  4. Attempt to fix pre-submit checks

    @Ilie-Lesan @brave-browser-releases
    Ilie-Lesan authored and brave-browser-releases committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    9b6ee09 View commit details
    Browse the repository at this point in the history

  5. Use std::optional instead of raw pointer

    @Ilie-Lesan @brave-browser-releases
    Ilie-Lesan authored and brave-browser-releases committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    cc8c7cc View commit details
    Browse the repository at this point in the history

  6. We still need the browser context forward declaration

    @Ilie-Lesan @brave-browser-releases
    Ilie-Lesan authored and brave-browser-releases committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    2a03a7f View commit details
    Browse the repository at this point in the history

  7. Review changes

    @Ilie-Lesan @brave-browser-releases
    Ilie-Lesan authored and brave-browser-releases committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    dd00ac5 View commit details
    Browse the repository at this point in the history