Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - fix minor issues #95

Merged
merged 4 commits into from
May 7, 2024

Conversation

behnambm
Copy link
Contributor

@behnambm behnambm commented Sep 6, 2023

Hi,
I hope you're doing well! I'm excited to submit my first contribution to the project. I've made some refactoring changes to improve code quality in a few key areas.

Here's the changes:

  • Removed redundant type conversion.
  • Prevented variable shadowing & collision with the log package name.
  • Removed deprecated function usage.

I'm open to feedback and guidance from the project maintainers, and I'm enthusiastic about actively working on the project if given the chance. Please let me know if there are any additional changes or steps needed to merge this pull request. I'm eager to learn and collaborate.

Thank you for considering my contribution, and I look forward to your feedback.

@mschfh mschfh self-assigned this May 7, 2024
@mschfh mschfh merged commit b4c279b into brave:master May 7, 2024
6 of 7 checks passed
@mschfh
Copy link
Contributor

mschfh commented May 7, 2024

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants