Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: bedrock, move to claude 3.5 sonnet #149

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

thypon
Copy link
Member

@thypon thypon commented Jun 21, 2024

No description provided.

@brave brave deleted a comment from github-actions bot Aug 8, 2024
@brave brave deleted a comment from github-actions bot Aug 8, 2024
Copy link

github-actions bot commented Aug 8, 2024

anthropic debug - [puLL-Merge] - brave/pull-merge@149

Description

This PR updates the AI models used in the project, specifically changing the Bedrock model from Claude 3 Opus to Claude 3.5 Sonnet. The change is implemented across multiple files to ensure consistency in model usage and token counting.

Changes

Changes

  1. In action.cjs:

    • Updated the bedrock_models value from 'anthropic.claude-3-opus-20240229-v1:0' to 'anthropic.claude-3-5-sonnet-20240620-v1:0'.
  2. In src/bedrockExplainPatch.js:

    • Added support for token counting for the new model 'anthropic.claude-3-5-sonnet-20240620-v1:0' in the COUNT_TOKENS_HASHFUN object.
    • Changed the default model in the explainPatch function from 'anthropic.claude-3-opus-20240229-v1:0' to 'anthropic.claude-3-5-sonnet-20240620-v1:0'.

These changes indicate a shift from using the Claude 3 Opus model to the Claude 3.5 Sonnet model, which is likely a more recent or more appropriate model for the project's needs.

Possible Issues

While there are no major issues apparent in this change, it's worth noting that switching to a different AI model may potentially impact the system's performance or output quality. It would be advisable to test the new model thoroughly to ensure it meets the project's requirements and maintains or improves upon the previous model's capabilities.

Copy link

github-actions bot commented Aug 8, 2024

openai debug - [puLL-Merge] - brave/pull-merge@149

Description

This pull request updates the AI model versions used in the project. Specifically, it changes the default and available model identifiers for anthropic's Claude models to newer versions (i.e., anthropic.claude-3-5-sonnet-20240620-v1:0). The motivation for this change seems to be to leverage improvements or updates in the newer Claude models.

Possible Issues

  • Backward Compatibility: Ensure that the API changes or behavior of the new model versions are fully compatible with the existing code, inputs, and expected outputs.
  • Testing: There should be an extensive set of tests to validate that the new models perform as expected. If these tests are not in place, it could lead to undetected issues.
Changes

Changes

  • action.cjs

    • Changed the bedrock_models default from 'anthropic.claude-3-opus-20240229-v1:0' to 'anthropic.claude-3-5-sonnet-20240620-v1:0'
  • src/bedrockExplainPatch.js

    • Added a new entry 'anthropic.claude-3-5-sonnet-20240620-v1:0' to COUNT_TOKENS_HASHFUN
    • Changed the default models array in the explainPatch function from ['anthropic.claude-3-opus-20240229-v1:0'] to ['anthropic.claude-3-5-sonnet-20240620-v1:0']

Copy link

github-actions bot commented Aug 8, 2024

bedrock debug - [puLL-Merge] - brave/pull-merge@149

Description

This PR updates the Bedrock model used in the pull-merge action from 'anthropic.claude-3-opus-20240229-v1:0' to 'anthropic.claude-3-5-sonnet-20240620-v1:0'. The change is implemented across multiple files to ensure consistency and proper functionality with the new model.

Changes

Changes

  1. action.cjs:

    • Updated the bedrock_models value from 'anthropic.claude-3-opus-20240229-v1:0' to 'anthropic.claude-3-5-sonnet-20240620-v1:0'.
  2. src/bedrockExplainPatch.js:

    • Added 'anthropic.claude-3-5-sonnet-20240620-v1:0' to the COUNT_TOKENS_HASHFUN object, mapping it to the anthropicCountTokens function.
    • Changed the default model in the explainPatch function from 'anthropic.claude-3-opus-20240229-v1:0' to 'anthropic.claude-3-5-sonnet-20240620-v1:0'.

These changes indicate a shift from using the Claude 3 Opus model to the Claude 3.5 Sonnet model, which is likely a more recent or optimized version for the project's needs.

@thypon thypon merged commit 8c3bcd7 into main Aug 8, 2024
7 checks passed
@thypon thypon deleted the features/update-bedrock branch August 8, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant