brave-isolated-world.yaml: catch extra regex

brave · Jul 17, 2023 · fa85efa · fa85efa
1 parent 0569f69
commit fa85efa
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/.../brave-isolated-world-id-content-end.yaml → ...semgrep_rules/c/brave-isolated-world.yaml b/.../brave-isolated-world-id-content-end.yaml → ...semgrep_rules/c/brave-isolated-world.yaml
@@ -3,8 +3,12 @@ rules:
     metadata:
       author: Andrea Brancaleoni <abc@pompel.me>
       confidence: LOW
+      assignees: |
+        thypon
+        goodov
+        iefremov
       source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/c/brave-isolated-world-id-content-end.yaml
-    message: Security hotspot found (`ISOLATED_WORLD_ID_CONTENT_END`). A security-team member should analyze the code security for possible vulnerabilities.
+    message: Security hotspot found (`ISOLATED_WORLD`). A security-team member should analyze the code security for possible vulnerabilities.
     severity: WARNING
     languages:
       - generic
@@ -16,4 +20,6 @@ rules:
         - "*.h"
         - "*.hh"
         - "*.hcc" 
-    pattern-regex: ISOLATED_WORLD_ID_CONTENT_END
+    patterns:
+      - pattern-regex: ISOLATED_WORLD_ID_CONTENT_END
+      - pattern-regex: ISOLATED_WORLD_ID_BRAVE_INTERNAL
diff --git a/t3sts/semgrep_rules/brave-isolated-world-id-content-end.c b/t3sts/semgrep_rules/brave-isolated-world-id-content-end.c
@@ -5,4 +5,6 @@ constexpr int kBraveAdsIsolatedWorldId =
 int main() {
     // ruleid: brave-isolated-world-id-content-end
    int a = content::ISOLATED_WORLD_ID_CONTENT_END;
+    // ruleid: brave-isolated-world-id-content-end
+   int a = content::ISOLATED_WORLD_ID_BRAVE_INTERNAL;
 }