New ruleset: chromium-insecure-gurl.yaml #279
Conversation
thypon
force-pushed
the
feature/gurl-rule
branch
from
e2b0b48
to
1b30fef
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| // Blink-specific example: | ||
| // chromium-insecure-gurl | ||
| KURL url = ...; |
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] Use origin (rather than URL) for security decisions.
URLs are often not sufficient for security decisions, since the origin may not be present in the URL (e.g., about:blank), may be tricky to parse (e.g., blob: or filesystem: URLs), or may be opaque despite a normal-looking URL (e.g., the security context may be sandboxed). Use origins whenever possible.
https://chromium.googlesource.com/chromium/src/+/refs/heads/main/docs/security/origin-vs-url.md
Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/c/chromium-insecure-gurl.yaml
Cc @thypon @fmarier
| // chromium-insecure-gurl | ||
| KURL url = ...; | ||
| // chromium-insecure-gurl | ||
| scoped_refptr<SecurityOrigin> origin = SecurityOrigin::Create(url); |
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] Use origin (rather than URL) for security decisions.
URLs are often not sufficient for security decisions, since the origin may not be present in the URL (e.g., about:blank), may be tricky to parse (e.g., blob: or filesystem: URLs), or may be opaque despite a normal-looking URL (e.g., the security context may be sandboxed). Use origins whenever possible.
https://chromium.googlesource.com/chromium/src/+/refs/heads/main/docs/security/origin-vs-url.md
Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/c/chromium-insecure-gurl.yaml
Cc @thypon @fmarier
| @@ -0,0 +1,23 @@ | |||
| int main() { | |||
| // chromium-insecure-gurl | |||
| GURL url = ...; | |||
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] Use origin (rather than URL) for security decisions.
URLs are often not sufficient for security decisions, since the origin may not be present in the URL (e.g., about:blank), may be tricky to parse (e.g., blob: or filesystem: URLs), or may be opaque despite a normal-looking URL (e.g., the security context may be sandboxed). Use origins whenever possible.
https://chromium.googlesource.com/chromium/src/+/refs/heads/main/docs/security/origin-vs-url.md
Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/c/chromium-insecure-gurl.yaml
Cc @thypon @fmarier
| // chromium-insecure-gurl | ||
| GURL url = ...; | ||
| // chromium-insecure-gurl | ||
| GURL origin = url.DeprecatedGetOriginAsURL(); |
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] Use origin (rather than URL) for security decisions.
URLs are often not sufficient for security decisions, since the origin may not be present in the URL (e.g., about:blank), may be tricky to parse (e.g., blob: or filesystem: URLs), or may be opaque despite a normal-looking URL (e.g., the security context may be sandboxed). Use origins whenever possible.
https://chromium.googlesource.com/chromium/src/+/refs/heads/main/docs/security/origin-vs-url.md
Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/c/chromium-insecure-gurl.yaml
Cc @thypon @fmarier
Resolves: #272