nodejs-insecure-url-parse: add inline require('url') #300
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| function() { | ||
| // ruleid: nodejs-insecure-url-parse | ||
| uparser.parse("here lies dragons"); |
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] Avoid using url.parse() as it may cause security issues. Consider using the URL class instead.
Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/web/nodejs-insecure-url-parse.yaml
Cc @thypon @fmarier
| } | ||
|
|
||
| // ruleid: nodejs-insecure-url-parse | ||
| setTimeout(()=> uparser.parse("here lies dragons"), 1000); |
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] Avoid using url.parse() as it may cause security issues. Consider using the URL class instead.
Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/web/nodejs-insecure-url-parse.yaml
Cc @thypon @fmarier
| @@ -1,2 +1,17 @@ | |||
| // ruleid: nodejs-insecure-url-parse | |||
| url.parse("here lies dragons"); | |||
| // ruleid: nodejs-insecure-url-parse | |||
| require('url').parse("here lies dragons"); | |||
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] Avoid using url.parse() as it may cause security issues. Consider using the URL class instead.
Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/web/nodejs-insecure-url-parse.yaml
Cc @thypon @fmarier
| var uparser = require('url'); | ||
|
|
||
| // ruleid: nodejs-insecure-url-parse | ||
| uparser.parse("here lies dragons"); |
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] Avoid using url.parse() as it may cause security issues. Consider using the URL class instead.
Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/web/nodejs-insecure-url-parse.yaml
Cc @thypon @fmarier
No description provided.