-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodejs-insecure-url-parse: add inline require('url') #300
Conversation
|
||
function() { | ||
// ruleid: nodejs-insecure-url-parse | ||
uparser.parse("here lies dragons"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported by reviewdog 🐶
[semgrep] Avoid using url.parse() as it may cause security issues. Consider using the URL class instead.
Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/web/nodejs-insecure-url-parse.yaml
Cc @thypon @fmarier
} | ||
|
||
// ruleid: nodejs-insecure-url-parse | ||
setTimeout(()=> uparser.parse("here lies dragons"), 1000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported by reviewdog 🐶
[semgrep] Avoid using url.parse() as it may cause security issues. Consider using the URL class instead.
Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/web/nodejs-insecure-url-parse.yaml
Cc @thypon @fmarier
@@ -1,2 +1,17 @@ | |||
// ruleid: nodejs-insecure-url-parse | |||
url.parse("here lies dragons"); | |||
// ruleid: nodejs-insecure-url-parse | |||
require('url').parse("here lies dragons"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported by reviewdog 🐶
[semgrep] Avoid using url.parse() as it may cause security issues. Consider using the URL class instead.
Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/web/nodejs-insecure-url-parse.yaml
Cc @thypon @fmarier
var uparser = require('url'); | ||
|
||
// ruleid: nodejs-insecure-url-parse | ||
uparser.parse("here lies dragons"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported by reviewdog 🐶
[semgrep] Avoid using url.parse() as it may cause security issues. Consider using the URL class instead.
Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/web/nodejs-insecure-url-parse.yaml
Cc @thypon @fmarier
No description provided.