Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New rule: internal-digest-call #578

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

thypon
Copy link
Member

@thypon thypon commented May 3, 2024

No description provided.

@thypon thypon requested a review from a team as a code owner May 3, 2024 12:41
@brave brave deleted a comment from github-actions bot May 3, 2024
@thypon thypon force-pushed the features/indirect-digest-call branch from 9019191 to 0925d1f Compare May 3, 2024 12:49
@thypon thypon changed the title New rule: indirect-digest-call New rule: internal-digest-call May 3, 2024
@@ -0,0 +1,3 @@
def signature(**kwargs):
# ruleid: internal-digest-call
sig = _INTERNAL_DIGEST_NEVER_CALL_DIRECTLY(kwargs)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reported by reviewdog 🐶
[semgrep] Internal Digest Direct Call, never call this directly

Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/services/indirect-digest-call.yaml


Cc @thypon @bcaller

@thypon thypon force-pushed the features/indirect-digest-call branch from 0925d1f to ae6d5cb Compare May 3, 2024 12:55
@@ -0,0 +1,3 @@
def signature(**kwargs):
# ruleid: internal-digest-call
sig = _INTERNAL_DIGEST_NEVER_CALL_DIRECTLY(kwargs)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reported by reviewdog 🐶
[semgrep] Internal Digest Direct Call, never call this directly

Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/services/internal-digest-call.yaml


Cc @thypon @bcaller

@thypon thypon merged commit bd95699 into main May 3, 2024
7 checks passed
@thypon thypon deleted the features/indirect-digest-call branch May 3, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants