Skip to content
This repository has been archived by the owner on Oct 22, 2019. It is now read-only.

TemplateView's get_context only accept kwargs! #393

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

TemplateView's get_context only accept kwargs! #393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion userena/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class ExtraContextTemplateView(TemplateView):
extra_context = None

def get_context_data(self, *args, **kwargs):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, good catch. Thanks.

But this line should also be changed to (self, **kwargs) to make it more consistent. Could you do that? After that I will merge it.

context = super(ExtraContextTemplateView, self).get_context_data(*args, **kwargs)
context = super(ExtraContextTemplateView, self).get_context_data(**kwargs)
if self.extra_context:
context.update(self.extra_context)
return context
Expand Down