Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 640x512, 640x256, 320x256, 640x360, 512x192 and 960x540 modes and restored 512x384 mode to VDP #128

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

avalonbits
Copy link

@avalonbits avalonbits commented Oct 28, 2023

No description provided.

@avalonbits
Copy link
Author

@tomm this is the new PR, that replaces the one I accidentally closed

@avalonbits avalonbits changed the title Add 640x512 and 320x256 modes to VDP Add 640x512 and 320x256 modes and restored 512x384 mode to VDP Oct 28, 2023
@julianregel
Copy link

If the purpose of these additional modes is to provide a better integer scale for modern monitors, then possibly consider adding 960x540 as this is quarter "Full HD" (1920x1080). I'm assuming this would be in 2 colours only (but haven't checked, so maybe 4 colours would fit too?).

@BlastBrothers
Copy link

While we're at it... 720x540 would be quarter 1080p at 4:3...

@avalonbits
Copy link
Author

I have tested 640x360 (quarter 720p, 16 colors) and 960x540 (quarter 1080p, 2 colors) before and both work well.
I've added them both, but you will need vdp-gl 1.0.4 (which I just released) to get the 640x360 resolution.

@avalonbits
Copy link
Author

While we're at it... 720x540 would be quarter 1080p at 4:3...

Don' t think there are a lot of 1440x1080p monitors to justify that support. Also, I would need a working modeline for that, which fabgl does not have.

@avalonbits avalonbits changed the title Add 640x512 and 320x256 modes and restored 512x384 mode to VDP Add 640x512, 320x256, 640x360 and 950x540 modes and restored 512x384 mode to VDP Nov 3, 2023
@avalonbits avalonbits changed the title Add 640x512, 320x256, 640x360 and 950x540 modes and restored 512x384 mode to VDP Add 640x512, 320x256, 640x360 and 960x540 modes and restored 512x384 mode to VDP Nov 4, 2023
@avalonbits avalonbits changed the title Add 640x512, 320x256, 640x360 and 960x540 modes and restored 512x384 mode to VDP Add 640x512, 640x256, 320x256, 640x360, 512x192 and 960x540 modes and restored 512x384 mode to VDP Dec 6, 2023
@avalonbits
Copy link
Author

Now we have:

  • 640x512 with 4, 2 colors
  • 640x256 (stretched) with 16, 4 and 2 colors
  • 320x256 with 64, 16, 4 and 2 colors
  • 640x360 (quarter 720p) with 16, 4 and 2 colors
  • 512x384 (quarter 1024x768) with 16, 4 and 2 colors.
  • 512x192 (stretched) with 64, 16, 4 and 2 colors
  • 960x540 (quarter 1080p) with 2 colors.

Requires vdp-gl 1.0.5 (updated in this PR).

@avalonbits
Copy link
Author

@stevesims anything else you see missing here?

@avalonbits
Copy link
Author

@stevesims ping. Anything else I need to update here?

@avalonbits
Copy link
Author

Should i just close this PR?

@avalonbits
Copy link
Author

I would still like to merge this one. Anybody can review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants