Change to blinding variant slip77
#49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions for the different variants were added here: Blockstream/lwk@cfe9341
DescriptorBlindingKey::Elip151is intended1 for multisig scenarios, or cases when multiple BIP44 accounts are used. Neither of this fits our use-case.In addition, it has the drawback2 that
The ordinary descriptor is hardcoded in
lwk, so this is not a good choice for us.This PR is therefore switching to blinding key variant to
DescriptorBlindingKey::Slip77, where the descriptor blinding key is derived from the BIP32 seed.Fixes #29
Footnotes
https://github.com/ElementsProject/ELIPs/blob/main/elip-0151.mediawiki#motivation ↩
https://github.com/ElementsProject/ELIPs/blob/main/elip-0151.mediawiki#drawbacks ↩