Use configured lazy connect channel in sync service #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hydra-yse
approved these changes
Dec 22, 2024
dangeross
approved these changes
Dec 22, 2024
lib/core/src/sync/client.rs
Outdated
| &self, | ||
| ) -> Result<ProtoSyncerClient<InterceptedService<Channel, ApiKeyInterceptor>>, Error> { | ||
| let Some(channel) = self.grpc_channel.lock().await.clone() else { | ||
| return Err(anyhow!("Cannot run `set_record`: client not connected")); |
There was a problem hiding this comment.
Maybe a clearer error message?
Suggested change
| return Err(anyhow!("Cannot run `set_record`: client not connected")); | |
| return Err(anyhow!("Cannot get client: gRPC not available")); |
hydra-yse
pushed a commit
that referenced
this pull request
Dec 24, 2024
Use configured lazy connect channel in sync service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR after some time the sync requests started to receive transport errors. It seems that the default keep alive settings are not working well for this service and we have to configure the underline grpc channel properly.
Also the way we inject the API key has changed a bit to a more centralised point to keep the API calls cleaner.