Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React Native package #99

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Add React Native package #99

merged 1 commit into from
Apr 25, 2024

Conversation

dangeross
Copy link
Collaborator

This PR builds on #98 to add a React Native package structure and example project. The package can use the published maven/cocoapods dependencies or be run from locally build bindings.

@dangeross dangeross requested a review from ok300 April 19, 2024 15:22
@dangeross dangeross changed the title React Native package Add React Native package Apr 19, 2024
@dangeross dangeross requested a review from hydra-yse April 19, 2024 15:22
@dangeross dangeross force-pushed the savage-react-native-bindings branch from 6781af6 to ecb0201 Compare April 19, 2024 15:57
@dangeross dangeross force-pushed the savage-react-native-package branch from 70da655 to c6ee1f7 Compare April 19, 2024 18:08
@dangeross dangeross force-pushed the savage-react-native-bindings branch from ecb0201 to 97a01ee Compare April 24, 2024 10:39
@dangeross dangeross force-pushed the savage-react-native-package branch 3 times, most recently from 1cd2736 to 163d24d Compare April 24, 2024 19:42
Copy link
Contributor

@ok300 ok300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, the new docs changes make it clearer. I can confirm it works on Android.

LGTM!

@dangeross dangeross force-pushed the savage-react-native-bindings branch 2 times, most recently from eb2629e to 4efb664 Compare April 25, 2024 11:46
@dangeross dangeross force-pushed the savage-react-native-package branch from 163d24d to 52977ac Compare April 25, 2024 11:54
@dangeross dangeross force-pushed the savage-react-native-package branch from 52977ac to 14b7367 Compare April 25, 2024 11:57
Base automatically changed from savage-react-native-bindings to main April 25, 2024 12:13
@dangeross dangeross merged commit 6e0b59f into main Apr 25, 2024
2 checks passed
@dangeross dangeross deleted the savage-react-native-package branch April 25, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants