Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ForceOutput to write the spinner regardless of running in a TTY #136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kylecarbs
Copy link
Contributor

This isn't a breaking change, but relates to #131.

@kiwiz
Copy link

kiwiz commented Mar 31, 2022

I've been following along the convo in #131 and I think a better solution (albeit breaking change) would be to:

  • Default to printing output with a newline instead of erase control codes when the terminal isn't a TTY
    • Optionally decrease the output frequency?
  • Add an option to suppress output entirely when the terminal isn't a TTY

This results in readable output and staves off timeouts in CI environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants