This repository has been archived by the owner on Dec 26, 2023. It is now read-only.
make layerfile name definition validation tests more reliable #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vieiralucas
commented
Sep 13, 2023
Comment on lines
+130
to
134
| if tt.err == nil { | ||
| assert.NoError(t, err) | ||
| } else { | ||
| assert.NoError(t, tt.err) | ||
| assert.ErrorIs(t, err, tt.err) | ||
| } |
There was a problem hiding this comment.
Changed this because we should assert that there is an error or not based on tt.err being defined or not. That's because what is defined in tt is what we expect to happen.
There was a problem hiding this comment.
i see, thanks for the pointer
There was a problem hiding this comment.
Thank you for the contribution! 🤘
vieiralucas
commented
Sep 13, 2023
| } else { | ||
| assert.NoError(t, tt.err) | ||
| assert.ErrorIs(t, err, tt.err) |
There was a problem hiding this comment.
Also, it's fine to just use ErrorIs, I don't want this test to fail if we change error messages.
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this matters
Addresses #74 (comment)
@rafiramadhana check this out.