Add geolocation data to notice logs #14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR will populate the
remote_location
record in allnotice
events with geolocation data that's available for the IP address that's perceived to be the "remote" side of the connection that generated the event (see docs for more detail). Thanks to @JustinAzoff from the Zeek team that offered the tip in zeek/zeek#3674 for how we can accomplish this for all flavors ofnotice
event while continuing to consolidate all our config changes inlocal.zeek
.I've tested using an artifact from this actions run and the test data in repro2.pcap.gz.
Closes #10