Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Fix PHPUnit 12 deprecations #244

Merged
merged 1 commit into from
Sep 23, 2024
Merged

MNT Fix PHPUnit 12 deprecations #244

merged 1 commit into from
Sep 23, 2024

Conversation

emteknetnz
Copy link
Collaborator

@emteknetnz emteknetnz commented Sep 19, 2024 •
edited
Loading

Issue silverstripe/.github#305

Fixes:

BringYourOwnIdeas\Maintenance\Tests\Util\ApiLoaderTest::testCachedAddonsAreUsedWhenAvailable
MockBuilder::getMockForAbstractClass() is deprecated and will be removed in PHPUnit 12 without replacement.

BringYourOwnIdeas\Maintenance\Tests\Util\SupportedAddonsLoaderTest::testCallbackReturnsAddonsFromBody
returnArgument() is deprecated and will be removed in PHPUnit 12. Use $double->willReturnArgument() instead of $double->will($this->returnArgument())

@emteknetnz emteknetnz mentioned this pull request Sep 19, 2024
Closed
2 tasks
GuySartorelli
GuySartorelli approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit a99753e into bringyourownideas:4 Sep 23, 2024
8 checks passed
@GuySartorelli GuySartorelli deleted the pulls/4/phpunit12 branch September 23, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli