DEP Use stable version of silverstripe/supported-modules #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
GuySartorelli
approved these changes
Oct 17, 2024
emteknetnz
force-pushed
the
pulls/3/stable-sm
branch
from
eb63b99
to
ccead6d
Compare
emteknetnz
commented
Oct 20, 2024
emteknetnz
force-pushed
the
pulls/3/stable-sm
branch
from
ccead6d
to
9c828fc
Compare
emteknetnz
commented
Oct 20, 2024
| $task = UpdatePackageInfoTask::create(); | ||
| $oldVersionProvider = Injector::inst()->get(VersionProvider::class); | ||
| try { | ||
| $task = UpdatePackageInfoTask::create(); |
There was a problem hiding this comment.
This is to fix a long standing broken unit test when running sink with a forked framework version
The new try/finally block is to reset Injector::inst()->registerService($versionProvider, VersionProvider::class); back from the mock VersionProvider, to the original VersionProvder. Looking through the sapphire teststate code it's not immediately clear to me whether this is required or not (quite possibly it's not and it resets itself between tests), however I don't want to risk causing a regression later on in a subsequent unit test
Looking through the teststate stuff, it's not immediately clear to me whether or not resetting the
GuySartorelli
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#11428