Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link in versioned_docs/version-3.0.0/setup_details.md #148

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

YUUU23
Copy link
Contributor

@YUUU23 YUUU23 commented Jul 5, 2024

Fix broken link (invalid link format to quick_start sections) in versioned_docs/version-3.0.0/setup_details.md as errors were thrown by Docusaurus 3.0 causing npm build to fail

Copy link

github-actions bot commented Jul 5, 2024

Visit the preview URL for this PR (updated for commit 37e69c5):

https://ccv-honeycomb-docs--pr148-fix-link-setup3-0-m68z38ap.web.app

(expires Fri, 12 Jul 2024 20:01:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d403a110fede5b0308678a87537bf61d0597aef6

@YUUU23 YUUU23 changed the title Fix link setup3.0 Fix link in versioned_docs/version-3.0.0/setup_details.md Jul 5, 2024
@YUUU23 YUUU23 linked an issue Jul 5, 2024 that may be closed by this pull request
@YUUU23 YUUU23 self-assigned this Jul 5, 2024
@YUUU23 YUUU23 requested a review from RobertGemmaJr July 5, 2024 20:06
Copy link
Member

@RobertGemmaJr RobertGemmaJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the base branch to whichever you're working out of? It looks like this PR should go into doc-ver-3 but I'm not sure

@YUUU23 YUUU23 changed the base branch from main to doc-ver-3 July 9, 2024 03:31
@YUUU23
Copy link
Contributor Author

YUUU23 commented Jul 9, 2024

Could you update the base branch to whichever you're working out of? It looks like this PR should go into doc-ver-3 but I'm not sure

My bad! I just updated the base branch to merge it into doc-ver-3!

@YUUU23 YUUU23 requested a review from RobertGemmaJr July 9, 2024 03:33
Copy link
Member

@RobertGemmaJr RobertGemmaJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! This should fix the failing builds in the other branch

@YUUU23 YUUU23 merged commit a2c9288 into doc-ver-3 Jul 10, 2024
3 checks passed
@YUUU23 YUUU23 deleted the fix-link-setup3.0 branch July 10, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken links in versioned_docs/versions-3.0.0/setup_details.md
2 participants