Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: logging 2 – replace print in analysis_db files #176

Merged
merged 13 commits into from
Mar 20, 2024

Conversation

hollandjg
Copy link
Member

@hollandjg hollandjg commented Mar 4, 2024

@hollandjg hollandjg changed the title chore: logging 2 – replace print in analysis\_db files chore: logging 2 – replace print in analysis_db files Mar 4, 2024
@hollandjg hollandjg changed the base branch from main to feat-logger/1-remove-stdout-suppression March 4, 2024 23:16
@hollandjg hollandjg marked this pull request as ready for review March 4, 2024 23:39
Copy link
Member

@cpaniaguam cpaniaguam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions here.

src/icesat2_tracks/analysis_db/B02_make_spectra_gFT.py Outdated Show resolved Hide resolved
src/icesat2_tracks/analysis_db/B02_make_spectra_gFT.py Outdated Show resolved Hide resolved
src/icesat2_tracks/analysis_db/B02_make_spectra_gFT.py Outdated Show resolved Hide resolved
src/icesat2_tracks/analysis_db/B02_make_spectra_gFT.py Outdated Show resolved Hide resolved
src/icesat2_tracks/analysis_db/B06_correct_separate_var.py Outdated Show resolved Hide resolved
src/icesat2_tracks/analysis_db/B06_correct_separate_var.py Outdated Show resolved Hide resolved
src/icesat2_tracks/analysis_db/B06_correct_separate_var.py Outdated Show resolved Hide resolved
src/icesat2_tracks/analysis_db/B06_correct_separate_var.py Outdated Show resolved Hide resolved
src/icesat2_tracks/analysis_db/B06_correct_separate_var.py Outdated Show resolved Hide resolved
hollandjg and others added 2 commits March 5, 2024 15:39
Co-authored-by: Carlos Paniagua <cpaniaguam@gmail.com>
Co-authored-by: Carlos Paniagua <cpaniaguam@gmail.com>
cpaniaguam
cpaniaguam previously approved these changes Mar 5, 2024
Copy link
Member

@cpaniaguam cpaniaguam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

…er/2-replace-print-logger-analysis_db

# Conflicts:
#	src/icesat2waves/analysis_db/A02c_IOWAGA_thredds_prior.py
#	src/icesat2waves/analysis_db/B02_make_spectra_gFT.py
#	src/icesat2waves/analysis_db/B03_plot_spectra_ov.py
#	src/icesat2waves/analysis_db/B06_correct_separate_var.py
kmilo9999
kmilo9999 previously approved these changes Mar 18, 2024
Copy link
Collaborator

@kmilo9999 kmilo9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Base automatically changed from feat-logger/1-remove-stdout-suppression to main March 19, 2024 13:40
@hollandjg hollandjg dismissed stale reviews from kmilo9999 and cpaniaguam March 19, 2024 13:40

The base branch was changed.

Co-authored-by: Camilo Diaz <k.diaz99@gmail.com>
@hollandjg hollandjg merged commit 4d3f28d into main Mar 20, 2024
2 checks passed
@hollandjg hollandjg deleted the feat-logger/2-replace-print-logger-analysis_db branch March 20, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants