chore: logging 5 - remove prints from local_modules directory #179
Conversation
There was a problem hiding this comment.
Thanks for your contributions, John! I pointed some issues with updates to commented lines that seem to have been changed programmatically. What to do with them? If they are kept and used later, extra work would be needed to make the messages lazily evaluated. I also noted a number of specific opportunities for improvement.
I agree. A lot of these lines are also touched in #131 (and a lot will be removed), so I don't want to make all the corrections just yet. Once we see what the final merge looks like we can revisit here. I'm also mindful of the extra effort going through and fixing commented out code might add, and I feel like we're close to the point of diminishing returns here. (There's a strong argument that we hit that point two weeks ago when you said this would be too much work – it's been more work than I expected.) |
…gger/5-replace-print-logger-local_modules # Conflicts: # src/icesat2waves/local_modules/m_colormanager_ph3.py
…gger/5-replace-print-logger-local_modules
…gger/5-replace-print-logger-local_modules # Conflicts: # src/icesat2waves/local_modules/jonswap_gamma.py # src/icesat2waves/local_modules/m_colormanager_ph3.py # src/icesat2waves/local_modules/m_general_ph3.py # src/icesat2waves/local_modules/m_spectrum_ph3.py # src/icesat2waves/local_modules/m_tools_ph3.py
add more context to debug messages Co-Authored-By: Carlos Paniagua <68481491+cpaniaguam@users.noreply.github.com>
Co-Authored-By: Carlos Paniagua <68481491+cpaniaguam@users.noreply.github.com>
Co-Authored-By: Carlos Paniagua <68481491+cpaniaguam@users.noreply.github.com>
Co-Authored-By: Carlos Paniagua <68481491+cpaniaguam@users.noreply.github.com>
Co-Authored-By: Carlos Paniagua <68481491+cpaniaguam@users.noreply.github.com>
…er-local_modules' into feat-logger/5-replace-print-logger-local_modules
Co-authored-by: Carlos Paniagua <cpaniaguam@gmail.com>
| _logger.debug("self.iter") | ||
| self.iter.__dict__ | ||
| if self.iter2 is not None: | ||
| print("self.iter2") | ||
| _logger.debug("self.iter2") |
There was a problem hiding this comment.
Maybe something like _logger.debug("iter2: %s", self.iter2)? I don't think the current version is very useful as the value of the variable is not displayed.
Co-authored-by: Carlos Paniagua <cpaniaguam@gmail.com>
Co-authored-by: Camilo Diaz <k.diaz99@gmail.com>
Co-Authored-By: Carlos Paniagua <68481491+cpaniaguam@users.noreply.github.com>
…tps://github.com/brown-ccv/icesat2waves into feat-logger/5-replace-print-logger-local_modules
Co-authored-by: Carlos Paniagua <cpaniaguam@gmail.com>
Co-authored-by: Carlos Paniagua <cpaniaguam@gmail.com>
Co-authored-by: Carlos Paniagua <cpaniaguam@gmail.com>
Co-authored-by: Carlos Paniagua <cpaniaguam@gmail.com>
Co-authored-by: Carlos Paniagua <cpaniaguam@gmail.com>
…gger/5-replace-print-logger-local_modules
…gger/5-replace-print-logger-local_modules
…gger/5-replace-print-logger-local_modules
hollandjg
dismissed stale reviews from cpaniaguam and kmilo9999
The base branch was changed.
Builds on
resolves #196