Manage unix socket #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruceg
reviewed
Mar 21, 2022
There was a problem hiding this comment.
This does touch a number of files, but it is all necessary. I'm a fan of using UNIX sockets, as they frequently make more sense than TCP for niche use cases. Thanks for the contribution. Would you be able to add test cases to test/tests/protocols using unixserver from ucspi-unix (or equivalent)?
| @@ -134,6 +134,15 @@ Set the SMTP authentication password. | |||
| .BI source= HOSTNAME | |||
| Set the source address for connections to the remote host. | |||
| .TP | |||
| .BI unix-socket=\fISOCKETNAME | |||
There was a problem hiding this comment.
Note that since this is a .BI line, the \fI is unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #73