Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#87 - Fix in counting elements #90

Merged
merged 4 commits into from
Oct 19, 2023
Merged

#87 - Fix in counting elements #90

merged 4 commits into from
Oct 19, 2023

Conversation

brunohjs
Copy link
Owner

Proposed changes

Fixed #87 issue describes wrong element count on Element count section. In addition, small changes/improvements were made in general, like:

  • Change the word "grade" to "score".
  • Change the word "general score" to "overall score".
  • Inclusion logs that show scores.
  • For development, create the feature to release test versions (beta versions).
  • Change weight_function function.
  • Fix health_check_rasa_api NLU controller method.

Types of changes

What types of changes does your code introduce to project?
Put an x in the boxes that apply

  • Bugfix
  • New feature
  • Feature Update
  • Config Update
  • Test Update
  • Documentation Update
  • Other

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added or updated tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added or updated necessary documentation (if appropriate)

@brunohjs brunohjs added bug Something isn't working documentation Improvements or additions to documentation change Little change or update labels Oct 19, 2023
@brunohjs brunohjs self-assigned this Oct 19, 2023
@brunohjs brunohjs changed the base branch from main to develop October 19, 2023 21:15
@brunohjs brunohjs merged commit 2df79d4 into develop Oct 19, 2023
8 checks passed
@brunohjs brunohjs deleted the #87 branch October 19, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working change Little change or update documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Counting elements is incorrect pt. 2
1 participant