-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.3.1.2 #303
Merged
Merged
Release 2.3.1.2 #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge 2.3.1.1 release branch back to main
The `super` keyword used in a statement in the HTML footer template was missing parentheses to perform a method call; this caused the template rendering to emit a Python string describing the parent template object, instead of rendering the parent template as intended.
…e-fixup Fixup: add missing call operator in template
In pyproject.toml
If it's going to falsely break the builds on the regular, it's not worth it.
ChatGPT did *not* have the whole story. Not anywhere close.
Did _not_ like it inside the coretest template
Irritatingly strict
Slows commits, is an extra setup step, and really isn't *all* that helpful since the CI is set up to fail early if things don't lint.
Want to catch nonblackened code
Might be more to do, need to review this
URL format changed.
Still need to add the version and the release date, when the time comes.
jayaddison
reviewed
Dec 20, 2024
It's not a project-code fix, so it shouldn't go into 'Fixed'.
@jayaddison 2.3.1.2 is up on PyPI - hopefully this fixes the reproducibility issue, please open another ticket if not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.