Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functions are now working properly: #12

Merged
merged 1 commit into from
Nov 4, 2023
Merged

Functions are now working properly: #12

merged 1 commit into from
Nov 4, 2023

Conversation

pascalfribi
Copy link
Contributor

  • ChatThread.addFunctionResponse is now public so it can be used
  • Encoding of Arguments for assistant is now done, so it generates a String containing a JSON Dictionary. Otherwise it will not be accepted by openai
  • The content field is now encoded to content: null as it always needs to be present

@pascalfribi
Functions are now working properly:
216cacb 
- ChatThread.addFunctionResponse is now public so it can be used
- Encoding of Arguments for assistant is now done, so it generates a String containing a JSON Dictionary. Otherwise it will not be accepted by openai
- The content field is now encoded to content: null as it always needs to be present
@pascalfribi pascalfribi mentioned this pull request Nov 1, 2023
Closed
btfranklin
btfranklin approved these changes Nov 4, 2023
View reviewed changes
Copy link
Owner

@btfranklin btfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you very much for these fixes.

@btfranklin btfranklin merged commit 6ebaaad into btfranklin:main Nov 4, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btfranklin btfranklin btfranklin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pascalfribi @btfranklin