Multiversion support #13
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
ktlint
src/main/kotlin/dev/nyon/autodrop/AutoDrop.kt|71 col 58| Argument should be on a separate line (unless all arguments can fit a single line)
src/main/kotlin/dev/nyon/autodrop/AutoDrop.kt|71 col 61| Argument should be on a separate line (unless all arguments can fit a single line)
src/main/kotlin/dev/nyon/autodrop/AutoDrop.kt|71 col 78| Argument should be on a separate line (unless all arguments can fit a single line)
src/main/kotlin/dev/nyon/autodrop/config/ConfigHandler.kt|5 col 1| Wildcard import
src/main/kotlin/dev/nyon/autodrop/config/ConfigHandler.kt|28 col 28| Parameter should start on a newline
src/main/kotlin/dev/nyon/autodrop/config/ConfigHandler.kt|28 col 28| Parameter should start on a newline
src/main/kotlin/dev/nyon/autodrop/config/ConfigHandler.kt|32 col 17| A multiline expression should start on a new line
src/main/kotlin/dev/nyon/autodrop/config/YaclScreen.kt|3 col 1| Wildcard import
src/main/kotlin/dev/nyon/autodrop/config/YaclScreen.kt|58 col 17| A multiline expression should start on a new line
src/main/kotlin/dev/nyon/autodrop/config/YaclScreen.kt|91 col 66| Argument should be on a separate line (unless all arguments can fit a single line)
src/main/kotlin/dev/nyon/autodrop/config/YaclScreen.kt|91 col 83| Argument should be on a separate line (unless all arguments can fit a single line)
src/main/kotlin/dev/nyon/autodrop/config/YaclScreen.kt|102 col 15| A multiline expression should start on a new line
src/main/kotlin/dev/nyon/autodrop/config/YaclScreen.kt|102 col 15| Missing newline after "("
src/main/kotlin/dev/nyon/autodrop/config/YaclScreen.kt|104 col 22| Missing newline after "("
src/main/kotlin/dev/nyon/autodrop/config/YaclScreen.kt|104 col 22| Argument should be on a separate line (unless all arguments can fit a single line)
src/main/kotlin/dev/nyon/autodrop/config/YaclScreen.kt|110 col 17| Missing newline before ")"
src/main/kotlin/dev/nyon/autodrop/config/YaclScreen.kt|110 col 18| Missing newline before ")"
src/main/kotlin/dev/nyon/autodrop/config/YaclScreen.kt|110 col 105| Missing newline before ")"
src/main/kotlin/dev/nyon/autodrop/config/models/Archive.kt|10 col 27| Expected newline
src/main/kotlin/dev/nyon/autodrop/config/models/Archive.kt|10 col 27| Expected newline before annotation
src/main/kotlin/dev/nyon/autodrop/config/models/Archive.kt|10 col 77| Expected newline after last annotation
src/main/kotlin/dev/nyon/autodrop/config/models/Archive.kt|10 col 94| Expected newline
src/main/kotlin/dev/nyon/autodrop/util/IdentifierSerializer.kt|15 col 27| Parameter should start on a newline
src/main/kotlin/dev/nyon/autodrop/util/IdentifierSerializer.kt|15 col 27| Parameter should start on a newline
stonecutter.gradle.kts|4 col 29| A single line block comment after a code element on the same line must be replaced with an EOL comment
stonecutter.gradle.kts|4 col 29| Replace the block comment with an EOL comment
stonecutter.gradle.kts|6 col 30| A multiline expression should start on a new line
stonecutter.gradle.kts|11 col 30| A multiline expression should start on a new line
stonecutter.gradle.kts|14 col 2| Redundant newline (\n) at the end of file
| import kotlinx.coroutines.delay | ||
| import kotlinx.coroutines.launch | ||
| import kotlinx.coroutines.runBlocking | ||
| import kotlinx.coroutines.* |
There was a problem hiding this comment.
🚫 [ktlint] standard:no-wildcard-imports reported by reviewdog 🐶
Wildcard import
| GLFW.GLFW_KEY_J, | ||
| "autodrop" | ||
| ) | ||
| private val toggleKeyBind = KeyBindingHelper.registerKeyBinding( |
There was a problem hiding this comment.
🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line
| ) | ||
| private val toggleKeyBind = KeyBindingHelper.registerKeyBinding( | ||
| KeyMapping( | ||
| "Toggle AutoDrop", InputConstants.Type.KEYSYM, GLFW.GLFW_KEY_J, "autodrop" |
There was a problem hiding this comment.
🚫 [ktlint] standard:argument-list-wrapping reported by reviewdog 🐶
Argument should be on a separate line (unless all arguments can fit a single line)
| ) | ||
| private val toggleKeyBind = KeyBindingHelper.registerKeyBinding( | ||
| KeyMapping( | ||
| "Toggle AutoDrop", InputConstants.Type.KEYSYM, GLFW.GLFW_KEY_J, "autodrop" |
There was a problem hiding this comment.
🚫 [ktlint] standard:argument-list-wrapping reported by reviewdog 🐶
Argument should be on a separate line (unless all arguments can fit a single line)
| ) | ||
| private val toggleKeyBind = KeyBindingHelper.registerKeyBinding( | ||
| KeyMapping( | ||
| "Toggle AutoDrop", InputConstants.Type.KEYSYM, GLFW.GLFW_KEY_J, "autodrop" |
There was a problem hiding this comment.
🚫 [ktlint] standard:argument-list-wrapping reported by reviewdog 🐶
Argument should be on a separate line (unless all arguments can fit a single line)
| GLFW.GLFW_KEY_O, | ||
| "autodrop" | ||
| ) | ||
| private val menuKeyBind = KeyBindingHelper.registerKeyBinding( |
There was a problem hiding this comment.
🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line
| ) | ||
| private val menuKeyBind = KeyBindingHelper.registerKeyBinding( | ||
| KeyMapping( | ||
| "Open GUI", InputConstants.Type.KEYSYM, GLFW.GLFW_KEY_O, "autodrop" |
There was a problem hiding this comment.
🚫 [ktlint] standard:argument-list-wrapping reported by reviewdog 🐶
Argument should be on a separate line (unless all arguments can fit a single line)
| ) | ||
| private val menuKeyBind = KeyBindingHelper.registerKeyBinding( | ||
| KeyMapping( | ||
| "Open GUI", InputConstants.Type.KEYSYM, GLFW.GLFW_KEY_O, "autodrop" |
There was a problem hiding this comment.
🚫 [ktlint] standard:argument-list-wrapping reported by reviewdog 🐶
Argument should be on a separate line (unless all arguments can fit a single line)
| ) | ||
| private val menuKeyBind = KeyBindingHelper.registerKeyBinding( | ||
| KeyMapping( | ||
| "Open GUI", InputConstants.Type.KEYSYM, GLFW.GLFW_KEY_O, "autodrop" |
There was a problem hiding this comment.
🚫 [ktlint] standard:argument-list-wrapping reported by reviewdog 🐶
Argument should be on a separate line (unless all arguments can fit a single line)
| ) | ||
| .withColor(0xF99147), | ||
| false | ||
| ).withStyle(Style.EMPTY.withColor(0xF99147)), false |
There was a problem hiding this comment.
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)
No description provided.