-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Architecture #146
New Architecture #146
Conversation
🦋 Changeset detectedLatest commit: 0d754ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
You can rebase on main to fix the formatting CI error |
378c027
to
6663881
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the direction this is going, its exciting!
Couple of changes and questions I have here so far, and I marked the TODOs as well.
Make sure everything that's marked as public
has tsdoc on it even if they aren't generally made for the end user to use, because they'll show up in the generated docs site anyway. Might be good to use @internal
on those too.
Also, there are a few lines that just end with //
like there was a comment there that is now gone, is that intentional?
Good luck on your testing! 🎉
Regarding the For example, Biome would format a piece of code like this: await this.rest.put(Routes.applicationCommands(this.options.clientId), {
body: commands
}) I myself don't like this, so I'll put await this.rest.put(
Routes.applicationCommands(this.options.clientId), //
{ body: commands }
) |
Ah, that's a neat trick |
Co-authored-by: Shadow <william.shadow@outlook.com>
This reverts commit cf924be.
Any idea on the docs api script failing? Haven't tried to fix it yet but I haven't dug into how this version works |
Seems to be related to the copy-api.sh script, the action doesnt like |
#185 fixes this issue |
Finally done 😂😴 |
Code
Plugin
class thatClient
andLinkedRoles
extendscreateHandle
methodcreate-carbon
new templatesTesting
apps/
Documentation
Closes #99