Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow MYMETA.* files to be generated #112

Closed
wants to merge 1 commit into from
Closed

Allow MYMETA.* files to be generated #112

wants to merge 1 commit into from

Conversation

oalders
Copy link

@oalders oalders commented Mar 14, 2023

These files are needed for installation via App::cpm. See
skaji/cpm#234 This reverts a change which was
introduced in 7856005

@perlpunk
Copy link

Yes, we also need these files on openSUSE to generate the spec file with requirements.

@oalders
Copy link
Author

oalders commented Apr 3, 2023

@theory thoughts on this PR?

@theory
Copy link
Contributor

theory commented Apr 4, 2023

Uhhh…no? Seems reasonable. Can't think of why we'd want to prevent there creation of MYMETA files.

@turnstep
Copy link
Contributor

turnstep commented Apr 4, 2023

Closing as done elsewhere - sorry this took so long to get on my radar!

@turnstep turnstep closed this Apr 4, 2023
@perlpunk
Copy link

perlpunk commented Apr 4, 2023

@turnstep I just looked into the recent commits and saw that you are now including MYMETA.* files in the tarball.
They should not be included there as they will be generated during the installation process. Same as for example the Makefile should not be in the tarball.

@turnstep
Copy link
Contributor

turnstep commented Apr 4, 2023

Ugh, thanks. Trying to do too many things at once!

@turnstep turnstep reopened this Apr 4, 2023
These files are needed for installation via App::cpm. See
skaji/cpm#234 This reverts a change which was
introduced in 7856005
@oalders
Copy link
Author

oalders commented Apr 5, 2023

https://metacpan.org/pod/ExtUtils::MakeMaker#NO_MYMETA NO_MYMETA defaults to false anyway, so I think it's less confusing if it's just removed entirely. That seems simpler to me than having to figure out the double negative.

@turnstep
Copy link
Contributor

turnstep commented Apr 5, 2023

Works for me! MYMETA is now gone

@oalders
Copy link
Author

oalders commented Apr 5, 2023

Thanks @turnstep! Closed via f316f89

@oalders oalders closed this Apr 5, 2023
@oalders oalders deleted the mymeta branch April 5, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants