Issue #198: AppManager return timeout error when execut install comma…

…nd in docker container
buckyos · Apr 12, 2023 · 1d8a79f · 1d8a79f
1 parent 4c479a9
commit 1d8a79f
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/service/app-manager/src/docker_api.rs b/src/service/app-manager/src/docker_api.rs
@@ -264,16 +264,19 @@ impl DockerApi {
 
             match child.wait_timeout(Duration::from_secs(INSTALL_CMD_TIME_OUT_IN_SECS))? {
                 None => {
-                    error!("app {} run install cmd {} not return after {} secs, kill", id, &cmd, INSTALL_CMD_TIME_OUT_IN_SECS);
+                    let msg = format!("app {} run install cmd {} not return after {} secs, kill", id, &cmd, INSTALL_CMD_TIME_OUT_IN_SECS);
+                    error!("{}", &msg);
                     let _ = child.kill();
                     let _ = child.wait();
+                    return Err(BuckyError::new(BuckyErrorCode::Timeout, msg));
                 }
                 Some(status) => {
                     if status.success() {
                         info!("app {} run install cmd {} success", id, &cmd);
                     } else {
-                        error!("app {} run install cmd {}, exit code {}", id, &cmd, code_to_string(status.code()));
-                        return Err(BuckyError::from(BuckyErrorCode::Failed));
+                        let msg = format!("app {} run install cmd {}, exit code {}", id, &cmd, code_to_string(status.code()));
+                        error!("{}", &msg);
+                        return Err(BuckyError::new(BuckyErrorCode::Failed, msg));
                     }
                 }
             }