Skip to content

Commit

Permalink
add another test with v1
Browse files Browse the repository at this point in the history
  • Loading branch information
andrewparmet committed Nov 15, 2024
1 parent 54532d1 commit 0973244
Show file tree
Hide file tree
Showing 4 changed files with 63 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,11 @@ class LintWithProtobufGradleTest : ConfigOverrideableLintTests, AbstractLintTest
assertSuccess()
}

@Test
fun `lint a file with an implementation dependency and a lint config with the protobuf-gradle-plugin v1`() {
assertSuccess()
}

@Test
fun `lint a file with an implementation dependency and a lint config with the protobuf-gradle-plugin v2`() {
assertSuccess()
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
version: v1
lint:
ignore:
- google
- protokt
use:
- STANDARD
except:
- ENUM_ZERO_VALUE_SUFFIX
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
plugins {
id 'java'
id 'com.google.protobuf' version "$protobufGradleVersion"
id 'build.buf'
}

repositories {
mavenCentral()
}

protobuf {
protoc {
artifact = "com.google.protobuf:protoc:$protobufVersion"
}
}

compileJava.enabled = false

dependencies {
implementation "com.google.protobuf:protobuf-java:$protobufVersion"
implementation "com.toasttab.protokt:protokt-runtime:0.6.5"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
// Copyright 2024 Buf Technologies, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

syntax = "proto3";

package buf.test.v1;

import "protokt/protokt.proto";

message BasicMessage {
protokt.ProtoktFileOptions protokt_file_options = 1;

enum BrokenEnum {
BROKEN_ENUM_NONSPECIFIED = 0; // should be _UNSPECIFIED
}
}

0 comments on commit 0973244

Please sign in to comment.