Add v2 buf.yaml Configuration/PublishWithWorkspaceTest test cases #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drice-buf
changed the title
andrewparmet
approved these changes
Jul 29, 2024
jhump
reviewed
Jul 30, 2024
|
|
||
| private fun assertSuccess() { | ||
| val result = gradleRunner().withArguments(":tasks").build() | ||
| assertThat(result.output).doesNotContain("cannot use both the protobuf-gradle-plugin and a Buf workspace") |
There was a problem hiding this comment.
This feels a little bit brittle. If we tweak the wording of the error message, we could then break what this test is trying to cover, but this assertion would mean the test case actually passes. Is there nothing in the output to look for to change this to a contains call?
|
@jhump good point and will address in a new PR shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.