Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sha256 support for bzlmod case #61

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

adrianimboden
Copy link
Contributor

I started to use rules_rust, which uses rules_buf.
I also use bzlmod and download all dependencies ahead of time to support builds without internet access.

For this to work, all downloads from the internet need to provide sha256 hash in the download actions. I saw that for the WORKSPACE style usage, this already works (buf_download_releases already supports that).

This MR adds the correct hash for v1.28.1 and allows to also override the hash in addition to the version.

@CLAassistant
Copy link

CLAassistant commented Apr 29, 2024

CLA assistant check
All committers have signed the CLA.

@calebzulawski
Copy link

calebzulawski commented May 14, 2024

I just ran into this and would like this supported as well. We use --repository_disable_download in some situations and I am unable to use rules_lint which depends on rules_buf.

@srikrsna-buf srikrsna-buf changed the title enable sha256 support for bzlmod case Add sha256 support for bzlmod case May 15, 2024
@srikrsna-buf srikrsna-buf merged commit 35408b9 into bufbuild:main May 15, 2024
6 of 7 checks passed
@srikrsna-buf srikrsna-buf mentioned this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants