chore: polishing

buggregator · May 31, 2024 · 144cf7e · 144cf7e
1 parent f834bce
commit 144cf7e
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 10 deletions.
diff --git a/src/Config/Server/Files/XHProf.php b/src/Config/Server/Files/XHProf.php
@@ -5,7 +5,7 @@
 namespace Buggregator\Trap\Config\Server\Files;
 
 use Buggregator\Trap\Service\Config\PhpIni;
-use Buggregator\Trap\Service\FilesObserver\Filter\XHProf as Converter;
+use Buggregator\Trap\Service\FilesObserver\Converter\XHProf as Converter;
 
 /**
  * @internal

diff --git a/src/Proto/Frame/Profiler/Type.php b/src/Proto/Frame/Profiler/Type.php
@@ -12,4 +12,5 @@ enum Type: string
 {
  case XHProf = 'XHProf';
  case XDebug = 'XDebug';
+ case SPX = 'SPX';
 }
diff --git a/src/Service/Config/ConfigLoader.php b/src/Service/Config/ConfigLoader.php
@@ -59,7 +59,10 @@ private function injectValue(object $config, \ReflectionProperty $property, arra
 
  /** @var mixed $value */
  $value = match (true) {
- $attribute instanceof XPath => @$this->xml?->xpath($attribute->path)[$attribute->key],
+ $attribute instanceof XPath => (static fn(?array $value, int $key): mixed => match (true) {
+ \array_key_exists($key, $value) => $value[$key],
+ default => null,
+ })($this->xml?->xpath($attribute->path), $attribute->key),
  $attribute instanceof Env => $this->env[$attribute->name] ?? null,
  $attribute instanceof InputOption => $this->inputOptions[$attribute->name] ?? null,
  $attribute instanceof InputArgument => $this->inputArguments[$attribute->name] ?? null,

diff --git a/src/Service/FilesObserver/Filter/XHProf.php → ...ervice/FilesObserver/Converter/XHProf.php b/src/Service/FilesObserver/Filter/XHProf.php → ...ervice/FilesObserver/Converter/XHProf.php
@@ -2,8 +2,9 @@
 
 declare(strict_types=1);
 
-namespace Buggregator\Trap\Service\FilesObserver\Filter;
+namespace Buggregator\Trap\Service\FilesObserver\Converter;
 
+use Buggregator\Trap\Logger;
 use Buggregator\Trap\Proto\Frame\Profiler as ProfilerFrame;
 use Buggregator\Trap\Service\FilesObserver\FileInfo;
 use Buggregator\Trap\Service\FilesObserver\FrameConverter as FileFilterInterface;
@@ -13,6 +14,10 @@
  */
 final class XHProf implements FileFilterInterface
 {
+ public function __construct(
+ private readonly Logger $logger,
+ ) {}
+
  public function validate(FileInfo $file): bool
  {
  return $file->getExtension() === 'xhprof';
@@ -40,8 +45,7 @@ public function convert(FileInfo $file): \Traversable
  ),
  );
  } catch (\Throwable $e) {
- // todo log
- \var_dump($e->getMessage());
+ $this->logger->exception($e);
  }
  }
 
@@ -76,11 +80,11 @@ private function dataToPayload(array $data): array
  'callee' => $callee,
  'caller' => $caller,
  'cost' => [
- 'cpu' => (int) $value['cpu'],
- 'ct' => (int) $value['ct'],
- 'mu' => (int) $value['mu'],
- 'pmu' => (int) $value['pmu'],
- 'wt' => (int) $value['wt'],
+ 'cpu' => (int)$value['cpu'],
+ 'ct' => (int)$value['ct'],
+ 'mu' => (int)$value['mu'],
+ 'pmu' => (int)$value['pmu'],
+ 'wt' => (int)$value['wt'],
  ],
  ];