Fixed bug when trap()->return() function sent dumps twice

buggregator · Feb 16, 2024 · f86fac5 · f86fac5
1 parent 8817c0a
commit f86fac5
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 3 deletions.
diff --git a/src/Client/TrapHandle.php b/src/Client/TrapHandle.php
@@ -111,8 +111,6 @@ public function once(): self
      */
     public function return(int|string $key = 0): mixed
     {
-        $this->haveToSend() and $this->sendDump();
-
         if (\count($this->values) === 0) {
             throw new \InvalidArgumentException('No values to return.');
         }

diff --git a/src/Info.php b/src/Info.php
@@ -10,7 +10,7 @@
 class Info
 {
     public const NAME = 'Buggregator Trap';
-    public const VERSION = '1.4.1';
+    public const VERSION = '1.4.3';
     public const LOGO_CLI_COLOR = <<<CONSOLE
         \e[44;97;1m                                    \e[0m
         \e[44;97;1m      ▄█▀                  ▀█▄      \e[0m

diff --git a/tests/Unit/Client/TrapTest.php b/tests/Unit/Client/TrapTest.php
@@ -4,6 +4,11 @@
 
 namespace Buggregator\Trap\Tests\Unit\Client;
 
+use Buggregator\Trap\Client\TrapHandle\Counter;
+use Buggregator\Trap\Client\TrapHandle\Dumper;
+use Symfony\Component\VarDumper\Cloner\Data;
+use Symfony\Component\VarDumper\Dumper\DataDumperInterface;
+
 final class TrapTest extends Base
 {
     public function testLabel(): void
@@ -74,6 +79,18 @@ public function testReturn(): void
         $this->assertSame(42, \trap(42, 43)->return(10));
     }
 
+    public function testReturnSendsDumpOnce(): void
+    {
+        $dumper = $this->getMockBuilder(DataDumperInterface::class)
+            ->getMock();
+        $dumper->expects($this->once())
+            ->method('dump')
+            ->willReturnArgument(1);
+        Dumper::setDumper($dumper);
+
+        $this->assertSame(42, \trap(42)->return());
+    }
+
     public static function provideTrapTimes(): iterable
     {
         yield 'no limit' => [0, [false, false, false, false, false]];