CI: separate pest config and isolate pest from unit tests #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
maintenance
roxblnfk
changed the title
roxblnfk
force-pushed
the
separate-arch-tests
branch
2 times, most recently
from
d203fe6
to
db18fce
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #114 +/- ##
============================================
+ Coverage 22.81% 23.34% +0.52%
Complexity 1232 1232
============================================
Files 146 146
Lines 3791 3834 +43
============================================
+ Hits 865 895 +30
- Misses 2926 2939 +13 ☔ View full report in Codecov by Sentry. |
roxblnfk
force-pushed
the
separate-arch-tests
branch
from
db18fce
to
b84ca7c
Compare
|
@roxblnfk I would like to test this locally, before giving my approve, if this can wait some time. I think that this can be resolved without making separate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Pest is used for arch tests only. It uses separated config file to not to break phpunit
Why?
pest doesn't work well but we need to have arch tests
Checklist