Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve PHP 8.4 deprecations #144

Merged
merged 4 commits into from
Dec 7, 2024
Merged

Resolve PHP 8.4 deprecations #144

merged 4 commits into from
Dec 7, 2024

Conversation

roxblnfk
Copy link
Member

@roxblnfk roxblnfk commented Dec 7, 2024

What was changed

  • Code style preset updated
  • Fixed nullable parameters

Why?

To prevent deprecations messages

@github-actions github-actions bot added maintenance CI, dependencies etc tests Changes in the tests labels Dec 7, 2024
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 21.91%. Comparing base (df2ccbb) to head (aac71ba).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/Client/TrapHandle/Dumper.php 0.00% 1 Missing ⚠️
src/Handler/Http/Middleware/Resources.php 0.00% 1 Missing ⚠️
src/Sender/Frontend/Http/StaticFiles.php 0.00% 1 Missing ⚠️
src/Socket/Server.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #144      +/-   ##
============================================
- Coverage     22.25%   21.91%   -0.35%     
  Complexity     1333     1333              
============================================
  Files           157      157              
  Lines          4300     4294       -6     
============================================
- Hits            957      941      -16     
- Misses         3343     3353      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roxblnfk roxblnfk merged commit 97ad260 into master Dec 7, 2024
23 of 27 checks passed
@roxblnfk roxblnfk deleted the php-8-4 branch December 7, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance CI, dependencies etc tests Changes in the tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant