Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set cached_result=true when there is a cache hit in the execution ser… #7967

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

vanja-p
Copy link
Contributor

@vanja-p vanja-p commented Nov 26, 2024

…vice

Without this, these cache hits look like executions to bazel. I don't think it matters to functionality, but it does underreport the cache hit ratio.

…vice

Without this, these cache hits look like executions to bazel. I don't think it matters to functionality, but it does underreport the cache hit ratio.
@vanja-p vanja-p requested a review from bduffany November 26, 2024 20:49
@vanja-p vanja-p enabled auto-merge (squash) November 26, 2024 20:50
Copy link
Member

@bduffany bduffany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I could tell, it looks like this field is only ever plumbed through to bazel's remote exec log file, so this LGTM

@vanja-p vanja-p merged commit b67be1a into master Nov 26, 2024
15 checks passed
@vanja-p vanja-p deleted the vanja-cached-op branch November 26, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants