Document ScheduleTaskRequest.serialized_task #7975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bduffany
approved these changes
Nov 27, 2024
Comment on lines
+338
to
+339
| // Serialized build.bazel.remote.execution.v2.ExecutionTask. That proto | ||
| // depends on this one, so using the full type would create a build cycle. |
There was a problem hiding this comment.
nit: we could move ExecutionTask to scheduler.proto if we wanted to break this cycle, so the note about the dependency cycle feels a bit incidental. (We created this problem ourselves by tacking on ExecutionTask to the upstream API protos rather than adding our own package.) It might make sense to omit that part to avoid confusion, or maybe add some additional clarification.
There was a problem hiding this comment.
Clarified a bit more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.