Remove workspacefs loopback mount code #8064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bduffany
force-pushed
the
rm-mount-workspace-file
branch
from
e91ae28 to
310706f
Compare
bduffany
force-pushed
the
rm-mount-workspace-file
branch
from
310706f to
2218fcb
Compare
vadimberezniker
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We aren't actively using this code. The
debugfscodepath is probably "fast enough" since we updated it to only copy output paths in #7959, and also this code is likely to be supplanted by FUSE anyway. If we do want to try this code again in the future, we can always bring it back, but should test thoroughly in dev first because we hit some issues with the loopback device approach last time.