Surface slow interrupt warnings in the executor logs #8094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerwilliams
approved these changes
Dec 19, 2024
maggie-lou
reviewed
Dec 19, 2024
| // and may help explain action failures - surface these in the executor | ||
| // logs. | ||
| if warning := c.parseSlowInterruptWarning(); warning != "" { | ||
| log.CtxWarningf(ctx, "Slow interrupt warning reported in kernel logs: %q", warning) |
There was a problem hiding this comment.
nit: We could consolidate some of the logic in the 3 parseX functions. We translate the vmlog bytes buffer to a string 3 times in a row
There was a problem hiding this comment.
Factored out the logic for converting to string and replacing \r\n with \n
maggie-lou
approved these changes
Dec 19, 2024
bduffany
force-pushed
the
hrtimer-logs
branch
from
5fbd204 to
133d353
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to understand if these slow interrupt warnings are correlated with higher action failure rates. By logging these we can get a rough frequency chart from GCP then compare that to the action failure metrics in Grafana.