Fix Bitmaps element of v2.1 in visinfo.xsd #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thbeu
changed the title
GeorgDangl
reviewed
Jul 15, 2024
| @@ -25,7 +25,7 @@ | |||
| </xs:complexType> | |||
| </xs:element> | |||
| <!-- ISG Jira issue BCF-17: Add support for text in the viewpoints --> | |||
| <xs:element name="Bitmap" minOccurs="0" maxOccurs="unbounded"> | |||
| <xs:element name="Bitmaps" minOccurs="0" maxOccurs="unbounded"> | |||
There was a problem hiding this comment.
This would rename the individual elements each to Bitmaps, but they'd still all appear in a sequence in the parent object. I think it would be better to create a wrapper element Bitmaps which holds one or many Bitmap elements, like this:
<Visinfo>
<Bitmaps>
<Bitmap>
<Reference>123</Reference>
</Bitmap>
<Bitmap>
<Reference>456</Reference>
</Bitmap>
<Bitmap>
<Reference>789</Reference>
</Bitmap>
</Bitmaps>
</Visinfo>There was a problem hiding this comment.
Ah, yes. This was my intention, but done wrong.
There was a problem hiding this comment.
@GeorgDangl Please check again. It looks similar to Lines/Line or ClippingPlanes/ClippingPlane to me (with some exceptions on minOccurs/maxOccurs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bitmaps element in v2.1 is wrong and needs to be fixed.
Unfortunately there is not a single v2.1 test case that has this optional element set.