BC003 AL01 - improving documentation #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Evandro Alfieri <62438551+evandroAlfieri@users.noreply.github.com>
Co-authored-by: Evandro Alfieri <62438551+evandroAlfieri@users.noreply.github.com>
evandroAlfieri
requested changes
Aug 24, 2023
There was a problem hiding this comment.
This diagram is adding requirements on the use of IfcRelPositions that are not further documented within the test instructions, nor in the IFC specification (e.g., between two alignments, between an alignment and a spatial structure element). Please clarify the requirements, possibly referring to existing IFC documentation.
This was referenced Aug 24, 2023
pjanck
commented
Aug 25, 2023
There was a problem hiding this comment.
@evandroAlfieri Please see section Link to requirements at the end of the readme.
Comment on lines
+131
to
+137
| | RI 86 | Unique containment | "Each IfcElement shall be either: - contained in one and only one IfcSpatialStructureElement, or - contained in one and only one IfcLinearPositioningElement." | RA-75 | | ||
| | RI 305 | Alignment organization | CableCarrier alignments shall be related to the track alignment with IfcRelPositions relationship | Cable carrier alignments shall be related to the track alignment | | ||
| | RI 311 | Alignement extruded geometry placement | A IfcCableCarrierSement which geometry is a IfcSectionSolidHorizontal shall be using the same IfcObjectPlacement as the IfcAlignment it is positioned along | NIL| | ||
| | RI 312 | Offset alignment placement | An IfcAlignment which geometry is a IfcOffsetCurveByDistances shall use the same IfcLocalPlacement as the IfcAlignment is relates to | NIL| | ||
| | RI 313 | Extruded CableCarrier positioning | A IfcSectionedSolidHorizontal geometry used for a IfcCableCarrierElement positioned relatively from an IfcAlignment shall use its IfcLocalPlacement | NIL | | ||
| | RI 314 | Project structure | The only "container" aggregated to the project shall be either IfcSite, IfcFacility, IfcAlignment. Other non-IfcProducts shall be connected to the project with IfcRelDeclares | NIL | | ||
| | RI 315 | Elements referencing in Spatial structures | If IfcElements are positioned wrt IfcPositioning elements, then they must be also referenced (instead of aggregated) into a IfcSpatialStructure element | NIL | |
There was a problem hiding this comment.
that are not further documented within the test instructions
Please see here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvements to