Replace SVG diagrams with PNG #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SVG diagrams were rendering with antialiasing artifacts, especially in Safari. For now we've decided to use PNG assets while we troubleshoot the rendering bug. This commit also updates the job state and build state diagrams to the new design language.
github-actions
bot
added
pipelines
|
@dannymidnight, any idea why this PR didn't trigger a preview? |
mbelton-buildkite
approved these changes
Aug 9, 2023
| @@ -113,7 +113,7 @@ When a step is run by an agent, it will be run with a clean checkout of the pipe | |||
|
|
|||
| When you run a pipeline, a build is created. The following diagram shows you how builds progress from start to end. | |||
|
|
|||
| <%= image "build-states.svg", size: "900x615", alt: "Build state diagram" %> | |||
| <%= image "build-states.png", alt: "Build state diagram" %> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SVG diagrams were rendering with antialiasing artifacts, especially in Safari. For now we've decided to use PNG assets while we troubleshoot the rendering bug.
This commit also updates the job state and build state diagrams to the new design language.